Refacto details top icons #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dtrucs
commented
Nov 14, 2024
dtrucs
commented
- Reduce the markup
- Add explicit label to button/link (a11y purpose)
dtrucs
force-pushed
the
Refacto-details-top-icons
branch
from
cd14a6e to
9b59d56
Compare
mabhub
reviewed
Nov 14, 2024
| </DetailsButton> | ||
| </ToolTip> | ||
| )} | ||
| {displayReport && Number(details.id) && getGlobalConfig().enableReport && ( |
There was a problem hiding this comment.
Suggested change
| {displayReport && Number(details.id) && getGlobalConfig().enableReport && ( | |
| {displayReport && Boolean(Number(details.id)) && getGlobalConfig().enableReport && ( |
(or it will display 0 in DOM if Number(details.id) is 0)
There was a problem hiding this comment.
Or maybe:
Suggested change
| {displayReport && Number(details.id) && getGlobalConfig().enableReport && ( | |
| {Boolean(displayReport && Number(details.id) && getGlobalConfig().enableReport) && ( |
There was a problem hiding this comment.
Or event better: preparing a variable like
const showMyContent = Boolean(displayReport && Number(details.id) && getGlobalConfig().enableReport);then:
Suggested change
| {displayReport && Number(details.id) && getGlobalConfig().enableReport && ( | |
| {showMyContent && ( |
mabhub
reviewed
Nov 14, 2024
Comment on lines
116
to
120
| {displayReservationWidget && | ||
| (details as Details).reservation && | ||
| (details as Details).reservation_id && | ||
| getGlobalConfig().reservationPartner && | ||
| getGlobalConfig().reservationProject && ( |
There was a problem hiding this comment.
Same as previous one: should be better with a tailored variable.
There was a problem hiding this comment.
Yes you're right for a better readability, i just pushed a commit with all suggestions 👍
(Cast the detail.id to number was useless and 0 value should not exist)
mabhub
approved these changes
Nov 14, 2024
Co-authored-by: mab <benjamin.marguin@makina-corpus.com>
dtrucs
force-pushed
the
Refacto-details-top-icons
branch
from
9b59d56 to
f4cf9d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.