Avoid unnecessary fetch for obtaining dictionaries #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrucs
force-pushed
the
develop
branch
4 times, most recently
from
1c45f81 to
9c7ca08
Compare
dtrucs
force-pushed
the
Avoid-uncessary-fetch-for-obtaining-dictionaries
branch
from
91fe631 to
7d070e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contents are linked to dictionaries such as cities, different types of categories, etc.
The application needs to get all elements at once whatever the count of items.
To do this, it fetches the first page of the list and retrieves the total count of items with the result.
If there are no others pages, it returns this result.
If not, it parallelizes the fetch of all pages to return the new result.
This PR concerns the "if not" part and avoids to re-fetch the first page, and concatenate its result with the news ones.