Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colorization of the map filter button #963

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

dtrucs
Copy link
Collaborator

@dtrucs dtrucs commented Sep 5, 2023

The map filter changes color when certain filters are selected or none, this was not working correctly as the map component is only rendered once.

Two fixes:

  • Re-render the component and set the toggle color dynamically
  • Fixed the className conflict defining the button background-color

One improvement:

  • Define an invisible label for the button (for a11y purposes).

@dtrucs dtrucs requested a review from a team September 5, 2023 13:53
@dtrucs dtrucs force-pushed the Fix-colorization-of-the-map-filter-button branch from 9f78621 to 1ad4fb6 Compare September 5, 2023 14:03
@dtrucs dtrucs merged commit dc432e2 into main Sep 6, 2023
1 check passed
@camillemonchicourt camillemonchicourt deleted the Fix-colorization-of-the-map-filter-button branch September 7, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants