Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshot taking #230

Open
wants to merge 7 commits into
base: feature/dsp-audio
Choose a base branch
from

Conversation

Epicpkmn11
Copy link

@Epicpkmn11 Epicpkmn11 commented Dec 1, 2021

This (tries to) add screenshot taking, at the moment it's rather broken as I'm not able to compile GBARunner2 myself to test and I'm not familiar with it's codebase, but I'll try fix it up soon.

The icon is the Photo Camera from Google Fonts, as GBARunner2 has a material design style so figured that's probably where the icons are from? It's also a bit of a bad scale down at the moment though so I'll probably try clean that up too.

Update: It works now!

@Epicpkmn11 Epicpkmn11 changed the base branch from master to feature/dsp-audio December 2, 2021 05:23
@Epicpkmn11
Copy link
Author

Rebased onto feature/dsp-audio as Azure works on this branch. I can rebase to something else if wanted when done, but this way I'm actually able to test. Sorry if I'm a bit spammier on commits than usual, I can't exactly test without committing.

@Epicpkmn11 Epicpkmn11 force-pushed the screenshots branch 3 times, most recently from 5c6a7a7 to cdfe825 Compare December 2, 2021 08:52
@Epicpkmn11 Epicpkmn11 force-pushed the screenshots branch 2 times, most recently from 4c92814 to 7ffe922 Compare December 2, 2021 09:26
@Epicpkmn11 Epicpkmn11 changed the title WIP: Add screenshot taking Add screenshot taking Dec 2, 2021
@Epicpkmn11
Copy link
Author

Epicpkmn11 commented Dec 2, 2021

Sorry about all the force pushing, Azure was my only method of testing and I wanted to keep the commits somewhat clean.

It works now though! The file naming could almost certainly be done better, however I've had a very hard time since GBARunner2 doesn't seem to like arrays or memcpy or a bunch of other things, so this is the best I've been able to do. It'll save screenshots to sd:/_gba/screenshots/screenshot-####.bmp where #### is a zero padded number.

Tested on DSi and DS, works both with and without center & mask on.
screenshot-0002 bmp screenshot-0017 bmp screenshot-0018 bmp screenshot-0022 bmp

Edit: Sometimes the first 48 lines are being missed, I've never seen it happen in MK:SC, but it's pretty common in LEGO Star Wars: The Video Game. This doesn't seem to be a new bug though as it's also missing on the copy while in the menu, even on master.
screenshot-0021 bmp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant