-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add screenshot taking #230
Open
Epicpkmn11
wants to merge
7
commits into
Gericom:feature/dsp-audio
Choose a base branch
from
Epicpkmn11:screenshots
base: feature/dsp-audio
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epicpkmn11
force-pushed
the
screenshots
branch
from
December 2, 2021 05:23
1db37e2
to
59cc2e4
Compare
Rebased onto feature/dsp-audio as Azure works on this branch. I can rebase to something else if wanted when done, but this way I'm actually able to test. Sorry if I'm a bit spammier on commits than usual, I can't exactly test without committing. |
Epicpkmn11
force-pushed
the
screenshots
branch
3 times, most recently
from
December 2, 2021 08:52
5c6a7a7
to
cdfe825
Compare
I can't compile GBARunner2 so there's a very high chance this doesn't work
Epicpkmn11
force-pushed
the
screenshots
branch
2 times, most recently
from
December 2, 2021 09:26
4c92814
to
7ffe922
Compare
Epicpkmn11
force-pushed
the
screenshots
branch
from
December 2, 2021 09:39
7ffe922
to
e34f5c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (tries to) add screenshot taking, at the moment it's rather broken as I'm not able to compile GBARunner2 myself to test and I'm not familiar with it's codebase, but I'll try fix it up soon.
The icon is the Photo Camera from Google Fonts, as GBARunner2 has a material design style so figured that's probably where the icons are from? It's also a bit of a bad scale down at the moment though so I'll probably try clean that up too.
Update: It works now!