Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix martor editors not working because of content security policy #284

Closed
fblampe opened this issue Aug 28, 2023 · 1 comment · Fixed by #297
Closed

Fix martor editors not working because of content security policy #284

fblampe opened this issue Aug 28, 2023 · 1 comment · Fixed by #297
Assignees
@cafischer

Comments

@fblampe
Copy link
Collaborator

fblampe commented Aug 28, 2023 •
edited
Loading

Editors just look like this and cannot be used:

Image

The reason are content security policy errors that show up in the browser console:

Image

They are caused by the updated nginx config: https://github.com/GermanZero-de/klimaschutzmonitor/pull/275/files#diff-1566418be847e3065680f7aa0ef6b85f31cee192217d17d0cce702e4ab916433R11

Looks like we might need some exceptions for martor..? @cafischer could you have a look at this since you probaly already looked into CSP stuff recently?
@fblampe fblampe changed the title Fix martor editors not working Fix martor editors not working because of content security policy Aug 28, 2023
fblampe added a commit that referenced this issue Aug 28, 2023
@fblampe
[#284] Workaround: Remove content security policy for now
6fc0c10
@fblampe fblampe mentioned this issue Aug 28, 2023
Merged
fblampe added a commit that referenced this issue Aug 28, 2023
@fblampe
Merge pull request #285 from GermanZero-de/284-fix-martor-csp-errors
d4c8d44 
[#284] Workaround: Remove content security policy for now
@fblampe
Copy link
Collaborator Author

fblampe commented Aug 28, 2023

As a workaround, I removed the problematic line for now so we can keep deploying without breaking anything.
We should look into a more permanent fix that enables CSP with some exceptions though.

@cafischer cafischer self-assigned this Sep 1, 2023
cafischer added a commit that referenced this issue Sep 6, 2023
@cafischer
[#284] add content security header that works with martor
7308fc9
@cafischer cafischer mentioned this issue Sep 6, 2023
Merged
@mdrie mdrie closed this as completed in #297 Sep 7, 2023
mdrie added a commit that referenced this issue Sep 7, 2023
@mdrie
Merge pull request #297 from GermanZero-de/284-csp-martor-issue
d50afcf 
[#284] add content security header that works with martor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cafischer cafischer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#284] add content security header that works with martor GermanZero-de/localzero-monitoring
2 participants
@cafischer @fblampe