docs: Dark Mode applied in Storybook controls #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| appPreviewBg: 'var(--color-surface)', | ||
| appBorderColor: '#585C6D', | ||
| appBorderRadius: 4, | ||
| appBg: tokens["color-base-blue--1000"], |
There was a problem hiding this comment.
As a follow up it would be good to use semantic tokens here!
There was a problem hiding this comment.
sounds good - I can probably do that as side desk work within this sprint
chris-at-jobber
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
The controls section in stories didn't have Dark Mode applied and it made it difficult to read the props, etc.
Changes
Changed
theme.tsso the controls section can be viewed in Dark ModeBefore
After
Testing
Look at any story, and make sure the controls section (with the props) responds to the sun/moon theme toggle in the top nav
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.