-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docx): Improve search experience in new docs site #2100
Conversation
Notes for additional improvements that might need more dev assistance:
|
Deploying atlantis with Cloudflare Pages
|
Component usage thoughts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment here on why Box could/should support some of these properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much effort to get Box to support them in your estimate? Is it something I could roll inside an hour or so?
onChange={d => setSearch(d as string)} | ||
/> | ||
<Box width="100%"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment on why Box didn't meet the needs here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Apologies on the delay. I need to clean up my GH notifications, it's 95% noise so I miss some of the signals.
Motivations
Searching the new docs site should be smooth and consumer grade! This cleans up some UI cruft and makes the search feel more intuitive.
Before
Screen.Recording.2024-11-02.at.2.26.27.PM.mov
After
Screen.Recording.2024-11-02.at.2.47.25.PM.mov
Changes
Added
Changed
Deprecated
Removed
Fixed
Security
Testing
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.