Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved types used by tests to CommonTestTypes, unifing them #145

Merged
merged 2 commits into from
Mar 14, 2018

Conversation

przemoli
Copy link

@przemoli przemoli commented Mar 9, 2018

#129
I moved types from test/Data/Swagger/{ParamSchemaSepc|SchemaSpec} to single module, and for duplicates I just copied extra Deriving and instances.

@fizruk
Copy link
Member

fizruk commented Mar 9, 2018

The problem with GHC 7.8 is that you have to import Control.Applicative to get pure and <$>.
Something like this should work:

#if __GLASGOW_HASKELL__ <710
import Control.Applicative
#endif

@fizruk
Copy link
Member

fizruk commented Mar 9, 2018

Also, apparently you have all the code indented by 2 whitespaces, that's probably unintended?

Apart from those comments seems good, thanks for your contribution!

@phadej
Copy link
Collaborator

phadej commented Mar 9, 2018

-#if __GLASGOW_HASKELL__ <710
-import Control.Applicative
-#endif
+import Prelude ()
+import Prelude.Compat

@fizruk fizruk mentioned this pull request Mar 9, 2018
@przemoli
Copy link
Author

przemoli commented Mar 12, 2018

I've updated imports to use Prelude.Compat, and I've rebased my commits on top of recent PR.

Edit: I still haven't fixed indentation. What should it be?
Edit2: Ok. Whole module was intended 2 whitespaces. Fixed.

@phadej phadej merged commit d8f9ec5 into GetShopTV:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants