-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to classy field lenses #41
Conversation
The downside of this change would be more ambiguous types, since names are overloaded now. I still have to check/update the documentation and, probably, write more about lenses and shortcut @dmjio, @jkarni I would appreciate you opinion/review on this PR. Note that these changes would affect |
This LGTM. It seems a lot nicer to use, and at least for my purposes ambiguity isn't an issue. One thing to note is that |
- use makeFields for records - remove prefixes even for ParamSchema accessors - Swagger record field names had to gain "swagger" prefix again - also remove Paths as a redundant structure
c93d0c5
to
d70163a
Compare
👍 |
|
Closes #39.
This change affects many names and types.
The goal is to make code look nicer.
Here's one example:
These names had to gain
_
suffix:type_
,in_
,default_
(keywords);minimum_
,maximum_
(conflict withPrelude
);enum_
(conflict withControl.Lens
).