Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Proposal: Don't run actions on draft PR's #1015

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

GroovinChip
Copy link
Contributor

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

It can be immensely aggravating to get constant emails of actions failing when adding commits to draft pull requests - #913 is a perfect example of this. I get bombarded with failure emails every time I push commits, and it's quite irritating.

Per a GitHub Community post that I found, I have set the actions to only run on regular PR's, and a one-line action to run on drafts that just prints a message (I think this is needed for the sake of being thorough?).

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #1015 (04194cf) into develop (2c8d22b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1015   +/-   ##
========================================
  Coverage    76.09%   76.09%           
========================================
  Files          192      192           
  Lines        20657    20657           
========================================
  Hits         15719    15719           
  Misses        4938     4938           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8d22b...04194cf. Read the comment docs.

@imtoori imtoori changed the title chore(flutter): Proposal: Don't run actions on draft PR's chore(repo): Proposal: Don't run actions on draft PR's Mar 17, 2022
@imtoori imtoori merged commit e1d46f5 into develop Mar 17, 2022
@GroovinChip GroovinChip deleted the no_actions_on_drafts branch March 17, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants