Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llc): send only user_id while reconnecting #1072

Merged
merged 7 commits into from
Apr 13, 2022

Conversation

imtoori
Copy link
Contributor

@imtoori imtoori commented Apr 11, 2022

No description provided.

@imtoori imtoori linked an issue Apr 11, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1072 (8a4f80c) into develop (432579e) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##           develop    #1072      +/-   ##
===========================================
- Coverage    76.13%   76.12%   -0.02%     
===========================================
  Files          193      193              
  Lines        20686    20694       +8     
===========================================
+ Hits         15749    15753       +4     
- Misses        4937     4941       +4     
Impacted Files Coverage Δ
packages/stream_chat/lib/src/ws/websocket.dart 88.46% <80.00%> (-0.43%) ⬇️
packages/stream_chat/lib/src/client/client.dart 90.59% <100.00%> (ø)
...ages/stream_chat/lib/src/core/api/channel_api.dart 97.41% <0.00%> (-2.59%) ⬇️
packages/stream_chat/lib/src/client/channel.dart 63.42% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432579e...8a4f80c. Read the comment docs.

xsahil03x
xsahil03x previously approved these changes Apr 12, 2022
Copy link
Member

@xsahil03x xsahil03x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtoori imtoori merged commit 0b2330e into develop Apr 13, 2022
@xsahil03x xsahil03x deleted the hotfix/userReconnection branch May 1, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

send only user_id when reconnecting
2 participants