Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use ogScrapeUrl for link attachments #1104

Merged
merged 5 commits into from
Apr 26, 2022

Conversation

imtoori
Copy link
Contributor

@imtoori imtoori commented Apr 26, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1104 (f34705d) into develop (4223048) will decrease coverage by 0.00%.
The diff coverage is 15.00%.

@@             Coverage Diff             @@
##           develop    #1104      +/-   ##
===========================================
- Coverage    76.11%   76.10%   -0.01%     
===========================================
  Files          193      193              
  Lines        20697    20699       +2     
===========================================
  Hits         15753    15753              
- Misses        4944     4946       +2     
Impacted Files Coverage Δ
...t_flutter/lib/src/attachment/attachment_title.dart 0.00% <0.00%> (ø)
...hat_flutter/lib/src/attachment/url_attachment.dart 0.00% <0.00%> (ø)
...ackages/stream_chat_flutter/lib/src/extension.dart 28.81% <0.00%> (-0.76%) ⬇️
...ges/stream_chat_flutter/lib/src/message_input.dart 38.16% <0.00%> (ø)
...am_chat_flutter/lib/src/quoted_message_widget.dart 0.00% <0.00%> (ø)
packages/stream_chat_flutter/lib/src/utils.dart 43.45% <0.00%> (ø)
...stence/lib/src/stream_chat_persistence_client.dart 92.97% <ø> (ø)
...es/stream_chat_flutter/lib/src/message_widget.dart 30.27% <40.00%> (ø)
...stream_chat_flutter/lib/src/message_list_view.dart 46.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4223048...f34705d. Read the comment docs.

Copy link
Member

@xsahil03x xsahil03x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtoori imtoori merged commit 5d0177d into develop Apr 26, 2022
@xsahil03x xsahil03x deleted the hotfix/attachmentDownload branch May 1, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants