Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llc): Added a new field called push provider name in addDevice api call #1107

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

ayush221b
Copy link
Contributor

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Push v2 supports adding a push_provider_name field to support creating different configurations for device and push provider.

@ayush221b ayush221b requested a review from imtoori April 27, 2022 12:55
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1107 (a370cb1) into develop (d58f727) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1107   +/-   ##
========================================
  Coverage    76.10%   76.10%           
========================================
  Files          193      193           
  Lines        20726    20729    +3     
========================================
+ Hits         15773    15776    +3     
  Misses        4953     4953           
Impacted Files Coverage Δ
packages/stream_chat/lib/src/client/client.dart 90.57% <100.00%> (ø)
...kages/stream_chat/lib/src/core/api/device_api.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d58f727...a370cb1. Read the comment docs.

@imtoori imtoori merged commit ccd58ef into develop Apr 27, 2022
@xsahil03x xsahil03x deleted the add/push_provider_name branch May 1, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants