Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core, ui): add grid views, minor refactoring #1109

Merged
merged 6 commits into from
Apr 29, 2022
Merged

Conversation

xsahil03x
Copy link
Member

No description provided.

Signed-off-by: xsahil03x <xdsahil@gmail.com>
@xsahil03x xsahil03x requested a review from imtoori April 29, 2022 09:01
Signed-off-by: xsahil03x <xdsahil@gmail.com>
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1109 (51a3711) into v4 (38ace99) will decrease coverage by 0.49%.
The diff coverage is 1.99%.

@@            Coverage Diff             @@
##               v4    #1109      +/-   ##
==========================================
- Coverage   68.34%   67.84%   -0.50%     
==========================================
  Files         218      227       +9     
  Lines       23244    23407     +163     
==========================================
- Hits        15885    15880       -5     
- Misses       7359     7527     +168     
Impacted Files Coverage Δ
...src/v4/message_input/stream_attachment_picker.dart 33.18% <ø> (ø)
.../channel_scroll_view/stream_channel_grid_tile.dart 0.00% <0.00%> (ø)
.../channel_scroll_view/stream_channel_grid_view.dart 0.00% <0.00%> (ø)
.../channel_scroll_view/stream_channel_list_tile.dart 0.00% <ø> (ø)
.../channel_scroll_view/stream_channel_list_view.dart 1.36% <0.00%> (ø)
...h_scroll_view/stream_message_search_grid_view.dart 0.00% <0.00%> (ø)
...h_scroll_view/stream_message_search_list_tile.dart 0.00% <ø> (ø)
...h_scroll_view/stream_message_search_list_view.dart 1.66% <0.00%> (ø)
...4/scroll_view/stream_scroll_view_empty_widget.dart 0.00% <0.00%> (ø)
...4/scroll_view/stream_scroll_view_error_widget.dart 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d77061...51a3711. Read the comment docs.

Signed-off-by: xsahil03x <xdsahil@gmail.com>
Signed-off-by: xsahil03x <xdsahil@gmail.com>
Signed-off-by: xsahil03x <xdsahil@gmail.com>
Signed-off-by: xsahil03x <xdsahil@gmail.com>
@imtoori imtoori merged commit eac9d09 into v4 Apr 29, 2022
@xsahil03x xsahil03x deleted the feat/grid-views branch May 1, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants