Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llc,ui,persistence): Deprecated Member.role in favor of Member.channelRole #1124

Merged
merged 6 commits into from
May 6, 2022

Conversation

ayush221b
Copy link
Contributor

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Deprecated role field in Member model and did all relevant changes across packages.

@ayush221b ayush221b requested review from imtoori and xsahil03x May 6, 2022 12:00
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1124 (d533c3f) into develop (2e8f630) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head d533c3f differs from pull request most recent head 7f1f8d2. Consider uploading reports for the commit 7f1f8d2 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1124   +/-   ##
========================================
  Coverage    67.94%   67.94%           
========================================
  Files          229      229           
  Lines        23590    23593    +3     
========================================
+ Hits         16028    16031    +3     
  Misses        7562     7562           
Impacted Files Coverage Δ
packages/stream_chat/lib/src/client/channel.dart 63.08% <0.00%> (ø)
...r/lib/src/v4/stream_channel_info_bottom_sheet.dart 0.00% <0.00%> (ø)
...at_persistence/lib/src/db/drift_chat_database.dart 70.00% <ø> (ø)
...ckages/stream_chat/lib/src/core/models/member.dart 60.52% <50.00%> (-0.59%) ⬇️
...chat_persistence/lib/src/mapper/member_mapper.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb7e50...7f1f8d2. Read the comment docs.

@imtoori imtoori merged commit de35944 into develop May 6, 2022
@xsahil03x xsahil03x deleted the chore/deprecate_member_role branch May 1, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants