Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llc, core): fix message pagination parameters #1144

Merged
merged 5 commits into from
May 17, 2022

Conversation

imtoori
Copy link
Contributor

@imtoori imtoori commented May 13, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1144 (e054310) into develop (9963af9) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

@@             Coverage Diff             @@
##           develop    #1144      +/-   ##
===========================================
- Coverage    68.11%   68.10%   -0.02%     
===========================================
  Files          229      229              
  Lines        23433    23438       +5     
===========================================
  Hits         15962    15962              
- Misses        7471     7476       +5     
Impacted Files Coverage Δ
...ackages/stream_chat/lib/src/core/api/requests.dart 19.04% <0.00%> (-2.58%) ⬇️
...lib/src/v4/message_input/stream_message_input.dart 30.48% <ø> (ø)
...ream_chat_flutter_core/lib/src/stream_channel.dart 62.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df32dc5...e054310. Read the comment docs.

Copy link
Member

@xsahil03x xsahil03x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtoori imtoori merged commit 8985a0f into develop May 17, 2022
@xsahil03x xsahil03x deleted the hotfix/messagePagination branch May 1, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants