Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(llc): remove dio deprecated methods #1172

Merged
merged 4 commits into from
May 20, 2022

Conversation

xsahil03x
Copy link
Member

Fixes: #1117

Signed-off-by: xsahil03x <xdsahil@gmail.com>
@xsahil03x xsahil03x requested a review from imtoori May 20, 2022 11:38
Signed-off-by: xsahil03x <xdsahil@gmail.com>
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #1172 (389bd8f) into develop (e51b7b1) will decrease coverage by 0.03%.
The diff coverage is 20.00%.

@@             Coverage Diff             @@
##           develop    #1172      +/-   ##
===========================================
- Coverage    68.08%   68.05%   -0.04%     
===========================================
  Files          228      228              
  Lines        23509    23487      -22     
===========================================
- Hits         16006    15983      -23     
- Misses        7503     7504       +1     
Impacted Files Coverage Δ
...eam_chat/lib/src/core/http/stream_http_client.dart 92.64% <0.00%> (-1.39%) ⬇️
...ib/src/core/http/interceptor/auth_interceptor.dart 96.29% <100.00%> (-1.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51b7b1...389bd8f. Read the comment docs.

xsahil03x added 2 commits May 20, 2022 17:49
Signed-off-by: xsahil03x <xdsahil@gmail.com>
Signed-off-by: xsahil03x <xdsahil@gmail.com>
@imtoori imtoori merged commit 8633ee2 into develop May 20, 2022
@xsahil03x xsahil03x deleted the feat/remove-dio-deprecations branch May 20, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove usage of deprecated Dio methods in llc
2 participants