Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Extract StreamMediaAttachmentBuilder widget #1816

Conversation

Mounix99
Copy link
Contributor

@Mounix99 Mounix99 commented Dec 16, 2023

Submit a pull request

Changes requested in issue

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

@Mounix99 Mounix99 changed the title Feat/extract stream media attachment builder widget feat(ui): Extract StreamMediaAttachmentBuilder widget Dec 16, 2023
kanat
kanat previously approved these changes Dec 21, 2023
Copy link
Contributor

@kanat kanat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (461986b) to head (dc201b4).

Current head dc201b4 differs from pull request most recent head 120f024

Please upload reports for the commit 120f024 to get more accurate results.

Files Patch % Lines
...ge_input/stream_message_input_attachment_list.dart 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1816      +/-   ##
==========================================
- Coverage   60.27%   59.18%   -1.09%     
==========================================
  Files         317      310       -7     
  Lines       18473    17809     -664     
==========================================
- Hits        11134    10540     -594     
+ Misses       7339     7269      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ment_builder_widget' into feat/extract_stream_media_attachment_builder_widget
@Mounix99 Mounix99 requested a review from kanat December 21, 2023 18:19
@Mounix99
Copy link
Contributor Author

@kanat can you please review it again ?

@Mounix99
Copy link
Contributor Author

Mounix99 commented Feb 2, 2024

Review and everything else takes too long, If someone from package developers can manage this PR by themselves, please do it! Thank you, in advance!

Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deven98 deven98 merged commit 5ea210e into GetStream:master Jun 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants