Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): Update stream_chat_flutter.dart to make accessible message_widget_content_components.dart #1943

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

guplem
Copy link
Contributor

@guplem guplem commented Jun 11, 2024

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested

Description of the pull request

Fixes #1941 by exporting the file in the main stream_chat_flutter file.

@guplem guplem changed the title Update stream_chat_flutter.dart to make accessible message_widget_content_components.dart refactor: Update stream_chat_flutter.dart to make accessible message_widget_content_components.dart Jun 11, 2024
@deven98 deven98 changed the title refactor: Update stream_chat_flutter.dart to make accessible message_widget_content_components.dart refactor(ui): Update stream_chat_flutter.dart to make accessible message_widget_content_components.dart Jun 11, 2024
@deven98
Copy link
Contributor

deven98 commented Jun 11, 2024

@guplem can you remove the redundant imports in the files? You will see them in the lint errors.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.23%. Comparing base (b8d3822) to head (46eb8c1).

Current head 46eb8c1 differs from pull request most recent head bea2689

Please upload reports for the commit bea2689 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1943   +/-   ##
=======================================
  Coverage   60.23%   60.23%           
=======================================
  Files         317      317           
  Lines       18493    18493           
=======================================
  Hits        11140    11140           
  Misses       7353     7353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guplem
Copy link
Contributor Author

guplem commented Jun 11, 2024

@guplem can you remove the redundant imports in the files? You will see them in the lint errors.

Done!

@deven98
Copy link
Contributor

deven98 commented Jun 11, 2024

Hey @guplem, there are more redundant imports in the files that need to be removed - you can also check the analysis on this PR for them. Additionally, you will also need to add a single line to the changelog (stream_chat_flutter/pubspec.yaml) in the upcoming section to explain the change.

I understand this may be repetitive for you so let me know if you do not have time for the changes and I can do them as well.

Thanks!

@guplem
Copy link
Contributor Author

guplem commented Jun 11, 2024

Hi @deven98

My mistake! I believe I've covered your requests. Thanks for your patience

Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deven98 deven98 merged commit ff924da into GetStream:master Jun 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

message_widget_content_components.dart is not accessible
2 participants