-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui): Update stream_chat_flutter.dart to make accessible message_widget_content_components.dart #1943
Conversation
@guplem can you remove the redundant imports in the files? You will see them in the lint errors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1943 +/- ##
=======================================
Coverage 60.23% 60.23%
=======================================
Files 317 317
Lines 18493 18493
=======================================
Hits 11140 11140
Misses 7353 7353 ☔ View full report in Codecov by Sentry. |
Done! |
Hey @guplem, there are more redundant imports in the files that need to be removed - you can also check the analysis on this PR for them. Additionally, you will also need to add a single line to the changelog (stream_chat_flutter/pubspec.yaml) in the upcoming section to explain the change. I understand this may be repetitive for you so let me know if you do not have time for the changes and I can do them as well. Thanks! |
Hi @deven98 My mistake! I believe I've covered your requests. Thanks for your patience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Submit a pull request
CLA
Description of the pull request
Fixes #1941 by exporting the file in the main
stream_chat_flutter
file.