Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): extends predicates to mobile #1947

Merged
merged 4 commits into from
Jun 14, 2024
Merged

fix(ui): extends predicates to mobile #1947

merged 4 commits into from
Jun 14, 2024

Conversation

deven98
Copy link
Contributor

@deven98 deven98 commented Jun 11, 2024

Fixes #1796

Earlier implementation was only listening for keystrokes on desktop. New implementation also does the same by default but allows the user to customise and add their own send and clear predicates.

@deven98 deven98 marked this pull request as ready for review June 12, 2024 11:55
@deven98 deven98 requested a review from Brazol June 12, 2024 11:57
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 60.23%. Comparing base (1806fab) to head (591b563).

Files Patch % Lines
...er/lib/src/message_input/stream_message_input.dart 14.28% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1947      +/-   ##
==========================================
- Coverage   60.26%   60.23%   -0.04%     
==========================================
  Files         317      317              
  Lines       18495    18506      +11     
==========================================
+ Hits        11146    11147       +1     
- Misses       7349     7359      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kanat kanat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deven98 deven98 merged commit a7f6652 into master Jun 14, 2024
20 of 22 checks passed
@deven98 deven98 deleted the fix/mobile-predicates branch June 14, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sendMessageKeyPredicate on Mobile
2 participants