Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): stops cached image from being used when channel image is not set #1949

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

deven98
Copy link
Contributor

@deven98 deven98 commented Jun 12, 2024

Fixes #1931

ChannelHeader no longer uses CachedNetworkImage if channel image is not set.

Copy link
Contributor

@Brazol Brazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.26%. Comparing base (ff924da) to head (5521f35).

Files Patch % Lines
...flutter/lib/src/channel/stream_channel_avatar.dart 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1949      +/-   ##
==========================================
+ Coverage   60.23%   60.26%   +0.02%     
==========================================
  Files         317      317              
  Lines       18493    18495       +2     
==========================================
+ Hits        11140    11146       +6     
+ Misses       7353     7349       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deven98 deven98 merged commit 1806fab into master Jun 12, 2024
16 checks passed
@deven98 deven98 deleted the fix/cached-image-error branch June 12, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Invalid argument(s): No host specified in URI" when channel has no image
2 participants