Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): onThreadTap has been added in MessageWidgetContent to enable thread tap action. #1988

Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix(ui): onThreadTap has been added in MessageWidgetContent to enable thread tap action. #1988

merged 2 commits into from
Nov 8, 2024

Conversation

roopak27
Copy link
Contributor

@roopak27 roopak27 commented Jul 18, 2024 •
edited
Loading

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

onThreadTap has been added in MessageWidgetContent to enable thread tap action.

@roopak27 roopak27 marked this pull request as ready for review July 18, 2024 05:32
@roopak27 roopak27 changed the title onThreadTap has been added in MessageWidgetContent to enable thread tap action. fix: onThreadTap has been added in MessageWidgetContent to enable thread tap action. Jul 18, 2024
@roopak27 roopak27 changed the title fix: onThreadTap has been added in MessageWidgetContent to enable thread tap action. fix(ui): onThreadTap has been added in MessageWidgetContent to enable thread tap action. Jul 18, 2024
@szechyjs
Copy link

I just ran into this problem today, would love to see this fix!

@github-actions github-actions bot added the Stale label Aug 16, 2024
@szechyjs
Copy link

@deven98 ping!

@github-actions github-actions bot removed the Stale label Aug 23, 2024
@github-actions github-actions bot added the Stale label Sep 12, 2024
@szechyjs
Copy link

szechyjs commented Oct 1, 2024

The stale bot is useless, not stale!

@deven98 deven98 removed the Stale label Oct 1, 2024
@deven98
Copy link
Contributor

deven98 commented Oct 1, 2024

Hey @roopak27 / @szechyjs apologies some changes are coming for the message widget that must be merged before this is merged. I will keep you posted but I will look at this soon.

@github-actions github-actions bot added the Stale label Oct 21, 2024
xsahil03x
xsahil03x approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@xsahil03x xsahil03x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xsahil03x xsahil03x merged commit 4afc504 into GetStream:master Nov 8, 2024
2 checks passed
@sgowda97 sgowda97 deleted the fix/onThreadTap branch November 11, 2024 05:33
@xsahil03x xsahil03x mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsahil03x xsahil03x xsahil03x approved these changes

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roopak27 @szechyjs @deven98 @xsahil03x