Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llc): allow setting http client adapter to use native http #2005

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

knaeckeKami
Copy link
Contributor

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

fixes #1989

@knaeckeKami knaeckeKami changed the title feat: allow setting http client adapter to use native http feat(stream_chat): allow setting http client adapter to use native http Aug 21, 2024
@deven98 deven98 changed the title feat(stream_chat): allow setting http client adapter to use native http feat(llc): allow setting http client adapter to use native http Aug 21, 2024
@knaeckeKami knaeckeKami mentioned this pull request Aug 21, 2024
1 task
@knaeckeKami knaeckeKami force-pushed the master branch 2 times, most recently from 3da1ef4 to d2db7f8 Compare August 21, 2024 10:09
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.17%. Comparing base (f964016) to head (2194e38).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2005   +/-   ##
=======================================
  Coverage   60.17%   60.17%           
=======================================
  Files         317      317           
  Lines       18519    18520    +1     
=======================================
+ Hits        11144    11145    +1     
  Misses       7375     7375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Brazol
Brazol previously approved these changes Aug 21, 2024
Copy link
Contributor

@Brazol Brazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/stream_chat/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Maciej Brażewicz <brazol@gmail.com>
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deven98
Copy link
Contributor

deven98 commented Aug 21, 2024

Thanks for the PR @knaeckeKami! This should be merged soon and the changes should be released in the next version. You can of course use the git version if you need the same immediately. Thanks!

@deven98 deven98 merged commit 3cb7033 into GetStream:master Aug 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using native HTTP
3 participants