Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llc): fixed unread count after member removed #843

Merged
merged 3 commits into from
Dec 29, 2021
Merged

Conversation

deven98
Copy link
Contributor

@deven98 deven98 commented Dec 29, 2021

Fixes #841

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #843 (ba63be0) into develop (e0f1357) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #843      +/-   ##
===========================================
- Coverage    76.22%   76.22%   -0.01%     
===========================================
  Files          189      189              
  Lines        20335    20336       +1     
===========================================
  Hits         15501    15501              
- Misses        4834     4835       +1     
Impacted Files Coverage Δ
packages/stream_chat/lib/src/client/channel.dart 64.07% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f1357...ba63be0. Read the comment docs.

Copy link
Contributor

@imtoori imtoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtoori imtoori merged commit 8ac2c36 into develop Dec 29, 2021
@xsahil03x xsahil03x deleted the unread-count-fix branch May 1, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unread count gets wrong number of unread messages when channel member gets added/removed
2 participants