fix: Introduce showFloatingDateDivider in MessageListView on an older version too
#895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@xsahil03x Can you please help me with the failing checks? Are they supposed to pass even for a fix on an old version like this one? |
|
Hey @rohan20 , not really needed it's failing due to melos. |
|
Can you also update the version and add a changelog entry for the same? Thanks |
|
Great. What should the version be? I see that we already have versions
|
|
@rohan20 let's do |
|
Done! Please merge and create a new tag! Thanks for all your help! ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the pull request
stream_chat_flutterdue to a cyclic dependencies issue that I haven't fixed yet. We need this change to fix an issue onstream_chat_flutter: ^2.0.0-nullsafety.2.