Automapper issue #3137
Merged
Automapper issue #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeniKadosh1
reviewed
Aug 1, 2023
| @@ -356,6 +317,29 @@ private void CopyCustomizedVariableConfigurations(VariableBase customizedVar, Va | |||
| originalVar.Publish = originalCopy.Publish; | |||
| } | |||
|
|
|||
| private void AutoMapVariableData(VariableBase customizedVar, ref VariableBase originalVar) | |||
| { | |||
| string varType = customizedVar.GetType().Name; | |||
There was a problem hiding this comment.
we said to have the Switch for all Variables types and place it on generic class to be used for any future need, no?
There was a problem hiding this comment.
ok, i'll move this function to some generic class but for Selection List, List variable the values are getting deleted after automap. if we map these variable with VariableBase class then its working fine.
MeniKadosh1
reviewed
Aug 8, 2023
|
|
||
| switch (varType) | ||
| { | ||
| case "VariableDateTime": |
There was a problem hiding this comment.
let's not do switch case by strings, use nameof(classType)
Maheshkale447
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution.
Before submitting this PR, please make sure: