skipped status update to RQM is configurable #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maheshkale447
requested changes
Sep 18, 2023
| foreach (ActivitiesGroup activGroup in businessFlow.ActivitiesGroups) | ||
| { | ||
|
|
||
| if (ALMCore.DefaultAlmConfig.IsSkippedUpdate == "False") |
There was a problem hiding this comment.
Update flag name to PublishSkipped
| return false; | ||
| if(isFlowskipped) | ||
| { | ||
| Reporter.ToLog(eLogLevel.INFO, $"Skippinng ALM Results Publish of '{businessFlow.Name}' Flow and testplan '{bfExportedID}' as skippedUpdate configured as {ALMCore.DefaultAlmConfig.IsSkippedUpdate}"); |
There was a problem hiding this comment.
Change log level to Debug
| if(isFlowskipped) | ||
| { | ||
| Reporter.ToLog(eLogLevel.INFO, $"Skippinng ALM Results Publish of '{businessFlow.Name}' Flow and testplan '{bfExportedID}' as skippedUpdate configured as {ALMCore.DefaultAlmConfig.IsSkippedUpdate}"); | ||
| result = $"Skippinng ALM Results Publish of '{businessFlow.Name}' Flow and 'testplan {bfExportedID}' as skippedUpdate configured as {ALMCore.DefaultAlmConfig.IsSkippedUpdate}"; |
There was a problem hiding this comment.
no need to add it to results as it will be considered as error in Publish operations
Ginger/GingerCore/ALM/RQMCore.cs
Outdated
| } | ||
| else | ||
| { | ||
| return ""; |
There was a problem hiding this comment.
Return should be false instead of empty string as it will fail in parsing
Maheshkale447
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution.
Before submitting this PR, please make sure: