Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Update Tool tip configured in the Excel Action Page #3247

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Data Update Tool tip configured in the Excel Action Page #3247

merged 4 commits into from
Sep 27, 2023

Conversation

manas-droid
Copy link
Contributor

@manas-droid manas-droid commented Sep 22, 2023 •
edited
Loading

Changed the ToolTip of certain inputs to make it clear in format can the strings be presented

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Help Libray document is updated accordingly for Feature changes.

Maheshkale447
Maheshkale447 reviewed Sep 25, 2023
View reviewed changes
Ginger/Ginger/Actions/ActionEditPages/ActExcelEditPage.xaml Outdated
@@ -48,7 +48,7 @@

<StackPanel>
<Label Style="{StaticResource @InputFieldLabelStyle}">Select Row(s) Where:</Label>
<Actions:UCValueExpression x:Name="SelectRowsWhereTextBox" Margin="0,0,105,0" ToolTip="[Column Name]=Value to filter the rows by, like: Available='Yes' or Num=1 or [Team Name]='Ginger'."/>
<Actions:UCValueExpression x:Name="SelectRowsWhereTextBox" Margin="0,0,105,0" ToolTip="[Column Name]=Value to filter the rows by, like: Available='Yes' or Num=1 or [Team Name]='Ginger' or Account=XYZ."/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add examples with space and special characters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Maheshkale447 Maheshkale447 merged commit 74f4e08 into master Sep 27, 2023
4 of 5 checks passed
@Maheshkale447 Maheshkale447 deleted the BugFix/ExcelDataStringIssue branch September 27, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maheshkale447 Maheshkale447 Maheshkale447 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manas-droid @Maheshkale447