Enhancement/lite db upgrade #3389
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,13 +18,11 @@ limitations under the License. | |
|
|
||
| using amdocs.ginger.GingerCoreNET; | ||
| using Amdocs.Ginger.Common; | ||
| using Amdocs.Ginger.Common.InterfacesLib; | ||
| using Amdocs.Ginger.CoreNET.DataSource; | ||
| using Amdocs.Ginger.Repository; | ||
| using GingerCore.DataSource; | ||
| using GingerCoreNET.SolutionRepositoryLib.RepositoryObjectsLib.PlatformsLib; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Data; | ||
|
|
@@ -86,6 +84,16 @@ public override void Execute() | |
| if (DataSource.DSType == DataSourceBase.eDSType.LiteDataBase) | ||
| { | ||
| GingerCoreNET.DataSource.GingerLiteDB liteDB = new GingerCoreNET.DataSource.GingerLiteDB(); | ||
| string value = GetInputParamValue("Value"); | ||
| if (!string.IsNullOrEmpty(value)) | ||
| { | ||
| ValueExpression mValueExpression = new(WorkSpace.Instance.RunsetExecutor.RunsetExecutionEnvironment, RunOnBusinessFlow, WorkSpace.Instance.SolutionRepository.GetAllRepositoryItems<DataSourceBase>()); | ||
| mValueExpression.Value = value; | ||
| ValueUC = mValueExpression.ValueCalculated; | ||
| } | ||
|
|
||
| LiteDBSQLTranslator liteDBSQLTranslator = new (this); | ||
| this.ValueExp = liteDBSQLTranslator.CreateValueExpression(); | ||
| string Query = ValueExp.Substring(ValueExp.IndexOf("QUERY=") + 6, ValueExp.Length - (ValueExp.IndexOf("QUERY=") + 7)); | ||
| liteDB.FileFullPath = WorkSpace.Instance.Solution.SolutionOperations.ConvertSolutionRelativePath(DataSource.FileFullPath); | ||
|
|
||
|
|
@@ -281,6 +289,24 @@ public override void Execute() | |
|
|
||
| } | ||
|
|
||
|
|
||
| private string mKeyName; | ||
| [IsSerializedForLocalRepository] | ||
| public string KeyName | ||
| { | ||
| get | ||
| { | ||
| return mKeyName; | ||
| } | ||
| set | ||
| { | ||
| if(!string.Equals(mKeyName , value)) | ||
| { | ||
| mKeyName = value; | ||
| OnPropertyChanged(nameof(KeyName)); | ||
| } | ||
| } | ||
| } | ||
| private eControlAction mControlAction; | ||
| [IsSerializedForLocalRepository] | ||
| public eControlAction ControlAction | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The catch block in the
GenerateBFReportmethod is empty. It's recommended to at least log the exception to aid in debugging if an error occurs.try { // ... existing code ... } catch (Exception ex) { + Reporter.ToLog(eLogLevel.ERROR, "Failed to generate business flow report", ex); }There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will make the necessary changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manas-droid Great, glad to hear that you'll make the changes. If you need any more assistance, feel free to ask!
🎉
New Learnings Added
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!