Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue for runner pass rate #3455

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

sudarshan0212
Copy link
Contributor

@sudarshan0212 sudarshan0212 commented Jan 17, 2024

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Summary by CodeRabbit

  • Bug Fixes
    • Refined the assignment of start times, run statuses, and counts of passed items in reports to ensure accuracy in data representation.

Copy link
Contributor

coderabbitai bot commented Jan 17, 2024

Walkthrough

Walkthrough

The recent updates to the codebase involve refining how certain properties are assigned in data mapping processes. These tweaks aim to improve the accuracy and efficiency of logging execution details, particularly focusing on the start time, run status, and count of passed child items.

Changes

File Path Summary of Changes
.../RunListenerLib/CenteralizedExecutionLogger/AccountReportEntitiesDataMapping.cs Modified property assignments for StartTimeStamp, RunStatus, and ChildPassedItemsCountAction.

Poem

In the burrows of code, a rabbit did hop,
Tweaking the logs with a skip and a bop.
Time stamps and statuses, all in a line,
🥕 Clean data trails, by design. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ae9627f and 16330cd.
Files selected for processing (1)
  • Ginger/GingerCoreNET/Run/RunListenerLib/CenteralizedExecutionLogger/AccountReportEntitiesDataMapping.cs (4 hunks)
Additional comments: 3
Ginger/GingerCoreNET/Run/RunListenerLib/CenteralizedExecutionLogger/AccountReportEntitiesDataMapping.cs (3)
  • 69-69: The assignment of StartTimeStamp to accountReportAction.StartTimeStamp directly from action.StartTimeStamp assumes that the action object's StartTimeStamp property is already set correctly. Ensure that the StartTimeStamp is being set as expected elsewhere in the code.
  • 369-369: The assignment of _InProgressStatus to accountReportRunSet.RunStatus is consistent with the other methods in this class, which set the status to "In Progress" at the start of an action, activity, or run. This is a good practice for maintaining consistency in status reporting.
  • 391-391: The conditional operator used to set accountReportRunSet.RunStatus is based on the RunSetExecutionStatus of runSetConfig. This logic seems to be correct, but it's important to ensure that RunSetExecutionStatus is being set correctly elsewhere in the code.

@MeniKadosh1 MeniKadosh1 merged commit 7299a64 into master Jan 18, 2024
8 of 9 checks passed
@MeniKadosh1 MeniKadosh1 deleted the fix_runner_rate_issue branch January 18, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants