-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing issue for runner pass rate #3455
Conversation
WalkthroughWalkthroughThe recent updates to the codebase involve refining how certain properties are assigned in data mapping processes. These tweaks aim to improve the accuracy and efficiency of logging execution details, particularly focusing on the start time, run status, and count of passed child items. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- Ginger/GingerCoreNET/Run/RunListenerLib/CenteralizedExecutionLogger/AccountReportEntitiesDataMapping.cs (4 hunks)
Additional comments: 3
Ginger/GingerCoreNET/Run/RunListenerLib/CenteralizedExecutionLogger/AccountReportEntitiesDataMapping.cs (3)
- 69-69: The assignment of
StartTimeStamp
toaccountReportAction.StartTimeStamp
directly fromaction.StartTimeStamp
assumes that theaction
object'sStartTimeStamp
property is already set correctly. Ensure that theStartTimeStamp
is being set as expected elsewhere in the code.- 369-369: The assignment of
_InProgressStatus
toaccountReportRunSet.RunStatus
is consistent with the other methods in this class, which set the status to "In Progress" at the start of an action, activity, or run. This is a good practice for maintaining consistency in status reporting.- 391-391: The conditional operator used to set
accountReportRunSet.RunStatus
is based on theRunSetExecutionStatus
ofrunSetConfig
. This logic seems to be correct, but it's important to ensure thatRunSetExecutionStatus
is being set correctly elsewhere in the code.
Thank you for your contribution.
Before submitting this PR, please make sure:
Summary by CodeRabbit