D38226_Flow control Flow Skipped Flow executing in Rerun Fixed

[prashelke]

Thank you for your contribution.
Before submitting this PR, please make sure:

• PR description and commit message should describe the changes done in this PR
• Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
• Latest Code from master or specific release branch is merged to your branch
• No unwanted\commented\junk code is included
• No new warning upon build solution
• Code Summary\Comments are added to my code which explains what my code is doing
• Existing unit test cases are passed
• New Unit tests are added for your development
• Sanity Tests are successfully executed for New and Existing Functionality
• Verify that changes are compatible with all relevant browsers and platforms.
• After creating pull request there should not be any conflicts
• Resolve all Codacy comments
• Builds and checks are passed before PR is sent for review
• Resolve code review comments
• Update the Help Library document to match any feature changes

Summary by CodeRabbit

• New Features
  • Enhanced control flow to automatically mark activities and actions as "Skipped" in business flows that are not executed, ensuring smoother transitions and clearer status reporting.

[coderabbitai]

Walkthrough

The recent update introduces a nuanced approach to managing business flows marked as Skipped within the execution engine. By automatically setting the status of both activities and actions under a skipped business flow to "Skipped" and recalculating the final status before moving on, the system ensures a smoother transition and clearer status reporting across workflows.

Changes

File Path	Change Summary
.../GingerCoreNET/Run/GingerExecutionEngine.cs	Added a new condition to handle Skipped business flows by setting activities and actions to "Skipped" and recalculating the final status.

🐇✨
In the realm of code, where logic does leap,
A change was made, not shallow but deep.
Skipped flows now gracefully rest,
Ensuring that every path is the best.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 97048ad and 7e56a00.

Files selected for processing (1)

• Ginger/GingerCoreNET/Run/GingerExecutionEngine.cs (1 hunks)

Additional comments: 2

Ginger/GingerCoreNET/Run/GingerExecutionEngine.cs (2)

• 520-526: The condition to set activities and actions status to "Skipped" is based on the ReRunConfigurations.Active flag and the current status of the business flow. Ensure that this logic aligns with the intended behavior for rerunning skipped flows. If the business flow's status is not meant to be changed under certain conditions, this might introduce unexpected behavior.
• 528-528: The logic to reset a business flow if its run status is Failed and ReRunConfigurations.Active is true seems appropriate for handling rerun scenarios. However, ensure that the Reset method on the business flow clears all necessary state to allow for a clean rerun. This might include resetting action statuses, clearing logs, or other stateful components of the business flow.

[coderabbitai]

The condition to set the business flow's activities and actions status to "Skipped" based on the ReRunConfigurations.Active flag and the business flow's status being Passed seems to be redundant with the previous condition. Consider consolidating these conditions if they are intended to achieve the same outcome, or clarify the distinction between them if they serve different purposes.