Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility UI improvement #3540

Merged

Conversation

prashelke
Copy link
Contributor

@prashelke prashelke commented Mar 6, 2024

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Summary by CodeRabbit

  • Style
    • Improved the layout and visual alignment of labels and elements in the Accessibility Testing Edit Page.
    • Adjusted the position of the FontAwesome icon for better visual integration within the UI.

Copy link
Contributor

coderabbitai bot commented Mar 6, 2024

Walkthrough

The latest updates focus on enhancing the user interface's accessibility and visual coherence. Adjustments were made to labels and ComboBox elements in the Accessibility Testing Edit Page, improving the layout and clarity of options presented to the user. Additionally, a visual tweak was applied to a FontAwesome icon within a MultiSelect ComboBox, aiming to refine its alignment for a cleaner, more intuitive user experience.

Changes

File Path Change Summary
.../ActionEditPages/ActAccessibilityTestingEditPage.xaml Added margins and content to xTargetLbl and xAnalyzerLbl labels; adjusted margins for xStdCB and xSeverityCB.
.../UserControlsLib/MultiSelectComboBox.xaml Adjusted FontAwesome icon "Solid_AngleDown" right margin for better visual alignment.

🐇✨
In the land of code and pix,
A rabbit hopped, its tricks to mix.
Labels aligned, margins fixed,
An icon shifted, its place affixed.
With every hop, the UI fixed,
A tale of tweaks, in code intermixed. 🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 6aa0920 and a0fa166.
Files selected for processing (2)
  • Ginger/Ginger/Actions/ActionEditPages/ActAccessibilityTestingEditPage.xaml (2 hunks)
  • Ginger/Ginger/UserControlsLib/MultiSelectComboBox.xaml (1 hunks)
Files skipped from review due to trivial changes (1)
  • Ginger/Ginger/UserControlsLib/MultiSelectComboBox.xaml
Additional comments: 4
Ginger/Ginger/Actions/ActionEditPages/ActAccessibilityTestingEditPage.xaml (4)
  • 14-14: The addition of Margin="0,10,0,0" and updating the Content to "Target :" for xTargetLbl improves the visual clarity and spacing, making it more accessible. This change aligns with the PR's objective to enhance UI accessibility.
  • 51-51: Similar to the xTargetLbl, the xAnalyzerLbl label has been updated with a margin and content change to "Analyze Option :". This adjustment enhances the label's visibility and clarity, contributing positively to the UI's accessibility.
  • 58-59: The adjustment of the Margin for xStdCB (standard ComboBox) to "75,0,0,0" is intended to improve the layout. However, it's important to ensure that this change does not negatively impact the alignment or the overall layout of the UI, especially in different screen sizes or resolutions.
  • 63-64: Adjusting the Margin for xSeverityCB (severity ComboBox) to "8,0,0,0" likely aims to improve the alignment and spacing of the element. As with xStdCB, it's crucial to verify that this change positively affects the UI's accessibility without unintended layout issues.

@Maheshkale447 Maheshkale447 merged commit 67a51e7 into Releases/Official-Release Mar 6, 2024
9 checks passed
@Maheshkale447 Maheshkale447 deleted the BugFix/AccessibilityUIImprovement branch March 6, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants