Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix - 38239 - Add 'Done' Button On Runset Runner Config Page #3558

Merged
merged 4 commits into from
Mar 27, 2024
Merged

BugFix - 38239 - Add 'Done' Button On Runset Runner Config Page #3558

merged 4 commits into from
Mar 27, 2024

Conversation

Shubhkar13
Copy link
Contributor

@Shubhkar13 Shubhkar13 commented Mar 22, 2024 •
edited by coderabbitai bot
Loading

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Summary by CodeRabbit

  • New Features
    • Enhanced window interaction with the addition of custom buttons.
  • Refactor
    • Improved code organization by adding a new namespace for better UI components management.
  • Bug Fixes
    • Fixed a bug related to window closing functionality.

@Shubhkar13
Bug: No 'Done' button is shown at the bottom of runset runner configu…
826940c 
…ration page.

RC: We were not explicitly passing the done button to the generic window.
Fix: Explicitly pass a 'Done' button to close the generic window.
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 22, 2024 •
edited
Loading

Walkthrough

This update introduces enhancements to the user interface within a specific window of an application. It involves adding a new button for improved window management, incorporating an additional namespace for UI controls, and tweaking a method for window loading to accommodate custom interaction buttons. These changes aim to refine the user experience by offering more intuitive window control options.

Changes

File Path Change Summary
.../RunsetRunnersConfigPage.xaml.cs Added System.Windows.Controls.Primitives namespace, created and handled a new button for window closing, modified LoadGenericWindow method for custom buttons.

🐰✨
In the land of code where windows glide,
A rabbit hopped, with changes to confide.
"A button here, a tweak there," it said,
Enhancing windows, ahead it led.
With namespaces new and interactions keen,
A smoother experience, now to be seen. 🌟
🐰💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ca6a276 and 826940c.
Files selected for processing (1)
  • Ginger/Ginger/RunSetPageLib/RunsetRunnersConfigPage.xaml.cs (2 hunks)
Additional comments: 2
Ginger/Ginger/RunSetPageLib/RunsetRunnersConfigPage.xaml.cs (2)
  • 22-22: The addition of System.Windows.Controls.Primitives namespace supports the new UI elements introduced in this file. This change is appropriate for the functionality being added.
  • 75-81: The modifications to the LoadGenericWindow method call, including the addition of the doneBtn to the winButtons list, are correctly implemented. This enhances the window's functionality by allowing for custom buttons.

Ginger/Ginger/RunSetPageLib/RunsetRunnersConfigPage.xaml.cs Outdated Show resolved Hide resolved
coderabbitai[bot]
coderabbitai bot reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 826940c and 3ff1ad2.
Files selected for processing (1)
  • Ginger/Ginger/RunSetPageLib/RunsetRunnersConfigPage.xaml.cs (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • Ginger/Ginger/RunSetPageLib/RunsetRunnersConfigPage.xaml.cs

@Shubhkar13 Shubhkar13 merged commit 3cc3c9e into master Mar 27, 2024
9 checks passed
@Shubhkar13 Shubhkar13 deleted the BugFix/38239-OKButtonOnRunnerConfig branch March 27, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai coderabbitai left review comments

@Maheshkale447 Maheshkale447 Maheshkale447 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shubhkar13 @Maheshkale447