[DefectId: 40044 & 40055] New Solution Application Validation and Environment Platform initialization

[manas-droid]

1. Added Validation to disallow creating a solution without selecting a main target application.
2. Added Platform to the duplicate environment created.
   Thank you for your contribution.
   Before submitting this PR, please make sure:

• PR description and commit message should describe the changes done in this PR
• Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
• Latest Code from master or specific release branch is merged to your branch
• No unwanted\commented\junk code is included
• No new warning upon build solution
• Code Summary\Comments are added to my code which explains what my code is doing
• Existing unit test cases are passed
• New Unit tests are added for your development
• Sanity Tests are successfully executed for New and Existing Functionality
• Verify that changes are compatible with all relevant browsers and platforms.
• After creating pull request there should not be any conflicts
• Resolve all Codacy comments
• Builds and checks are passed before PR is sent for review
• Resolve code review comments
• Update the Help Library document to match any feature changes

Summary by CodeRabbit

• New Features
  • Added support for MainFrame3270 driver type selection based on the platform type in application settings.
  • Improved application detail management for a smoother setup experience.
  • Enhanced the duplication functionality in environment settings to include platform properties.

[coderabbitai]

Walkthrough

These changes enhance the application's functionality by improving support for MainFrame platforms, refining the management of application details, and ensuring the integrity of duplicated environment applications. Specifically, the updates include setting the driver type for MainFrame applications, introducing new fields to track application details completion, and copying platform properties during application duplication to maintain consistency.

Changes

File Path	Change Summary
.../AddApplicationPage.xaml.cs	Added support for setting the MainFrame3270 driver type for MainFrame platforms.
.../AddSolutionPage.xaml.cs	Introduced isApplicationDetailsSet and mainAppDescription fields for better application details management.
.../EnvApplicationTreeItem.cs	Ensured Platform property is copied in the Duplicate method for EnvApplication.

🐰✨
In the realm of code, where changes abound,
A rabbit hopped in, making hardly a sound.
With a flick of its paw, and a twitch of its ear,
MainFrame support grew, far and near.
"To manage, to duplicate," it whispered with glee,
"Let’s make our software as good as can be!"
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 651f56a and 921e984.

Files selected for processing (3)

• Ginger/Ginger/SolutionWindows/AddApplicationPage.xaml.cs (1 hunks)
• Ginger/Ginger/SolutionWindows/AddSolutionPage.xaml.cs (5 hunks)
• Ginger/Ginger/SolutionWindows/TreeViewItems/EnvironmentsTreeItems/EnvApplicationTreeItem.cs (1 hunks)

Additional comments not posted (2)

Ginger/Ginger/SolutionWindows/AddSolutionPage.xaml.cs (2)

73-73: Add a user-friendly message or UI indication when isApplicationDetailsSet is false, to inform the user that application details need to be set before proceeding.

---

92-92: Ensure that mainAppDescription is properly sanitized or validated before using it to avoid potential security risks or unexpected behavior.

Also applies to: 322-323