Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defect ID: [40014] Set Dirty Flag on run set config #3582

Merged
merged 8 commits into from
Apr 8, 2024

Conversation

manas-droid
Copy link
Contributor

@manas-droid manas-droid commented Apr 5, 2024

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Summary by CodeRabbit

  • New Features
    • Added new event handlers to enhance user interactions with business flow configurations.
  • Enhancements
    • Improved data mapping capabilities by introducing logic to better handle changes and updates.
  • Style
    • Minor adjustments in code formatting for better readability and maintenance.

Copy link
Contributor

coderabbitai bot commented Apr 5, 2024

Walkthrough

The updates involve refining event handling and data mapping functionalities within a software project named Ginger. Specifically, obsolete references were removed, and new event handlers were introduced for better interaction management. Additionally, adjustments were made for variable display and setting logic to enhance user experience and data integrity, ensuring changes in certain conditions are accurately tracked.

Changes

Files Change Summary
.../Run/BusinessFlowRunConfigurationsPage.xaml.cs
.../UserControlsLib/UCDataMapping.xaml.cs
Removed references to Ginger.Variables.InputVariableRule, added event handlers for UI elements, adjusted variable display settings, and enhanced MappedValue setter logic in TemplateOptions for improved DirtyStatus management.

🐇✨
In Ginger's realm, where code does weave,
A rabbit hopped, on change's eve.
With every click and text anew,
It danced through code, as changes grew.
🌟 For variables and maps redefined,
A celebration of the coded kind.
🎉🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 651f56a and 1bd22ce.
Files selected for processing (2)
  • Ginger/Ginger/Run/BusinessFlowRunConfigurationsPage.xaml.cs (6 hunks)
  • Ginger/Ginger/UserControlsLib/UCDataMapping.xaml.cs (1 hunks)
Additional comments not posted (4)
Ginger/Ginger/Run/BusinessFlowRunConfigurationsPage.xaml.cs (4)

85-87: The addition of event handlers for MandatoryBusinessFlowCB.Click and RunDescritpion.ValueTextBox.TextChanged is implemented correctly.


106-113: The implementation of MandatoryBusinessFlow_Clicked follows best practices for event invocation.


115-122: The implementation of RunDescription_TextChanged follows best practices for event invocation.


189-190: The syntax and formatting adjustments in SetVariablesGridView method, including the addition of a comma and whitespace modifications, are correct and improve readability.

Ginger/Ginger/UserControlsLib/UCDataMapping.xaml.cs Outdated Show resolved Hide resolved
Maheshkale447
Maheshkale447 previously approved these changes Apr 5, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 1bd22ce and 9958cfa.
Files selected for processing (1)
  • Ginger/Ginger/UserControlsLib/UCDataMapping.xaml.cs (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • Ginger/Ginger/UserControlsLib/UCDataMapping.xaml.cs

@Maheshkale447 Maheshkale447 merged commit f7c1e67 into Releases/Beta Apr 8, 2024
1 check passed
@Maheshkale447 Maheshkale447 deleted the Defect/RunConfigDirtyStatus branch April 8, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants