Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra Connection String Changes #3585

Merged
merged 18 commits into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 72 additions & 13 deletions Ginger/GingerCoreNET/Database/NoSqlBase/GingerCassandra.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,18 @@
#endregion

using Amdocs.Ginger.Common;
using Amdocs.Ginger.CoreNET.RunLib.CLILib;
using Cassandra;
using GingerCore.Actions;
using GingerCore.NoSqlBase.DataAccess;
using HBaseNet.Const;
using Microsoft.Graph;
using Microsoft.Graph.SecurityNamespace;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using System.Security.Authentication;
using System.Text.RegularExpressions;
using System.Threading.Tasks;

Expand All @@ -37,32 +42,70 @@
dynamic myclass = null;
string mUDTName = null;



public override bool Connect()
{
try
{
string queryTimeoutString = "querytimeout=";
const string queryTimeoutString = "querytimeout=";
const string sslString = "ssl=";
int queryTimeout = 20000;//default timeout (20 seconds).
if (Db.DatabaseOperations.TNSCalculated.ToLower().Contains(queryTimeoutString.ToLower()))
string[] queryArray = Db.DatabaseOperations.TNSCalculated.Split(';');
aditydha marked this conversation as resolved.
Show resolved Hide resolved
SSLOptions sslOptions = null;
for (int i = 1; i < Math.Min(queryArray.Length, 3); i++)
aditydha marked this conversation as resolved.
Show resolved Hide resolved
{
string queryTimeoutValue = Db.DatabaseOperations.TNSCalculated.Substring(Db.DatabaseOperations.TNSCalculated.ToLower().IndexOf(queryTimeoutString.ToLower()) + queryTimeoutString.Length);
queryTimeout = Convert.ToInt32(queryTimeoutValue) * 1000;
}
switch (queryArray[i])

Check failure on line 56 in Ginger/GingerCoreNET/Database/NoSqlBase/GingerCassandra.cs

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

Ginger/GingerCoreNET/Database/NoSqlBase/GingerCassandra.cs#L56

Add a 'default' clause to this 'switch' statement.

Check notice on line 56 in Ginger/GingerCoreNET/Database/NoSqlBase/GingerCassandra.cs

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

Ginger/GingerCoreNET/Database/NoSqlBase/GingerCassandra.cs#L56

Replace this 'switch' statement with 'if' statements to increase readability.
{
case var str when str.Contains(queryTimeoutString):
string queryTimeoutValue = str.Substring(str.IndexOf(queryTimeoutString) + queryTimeoutString.Length);
if (!int.TryParse(queryTimeoutValue, out int timeout))
{
throw new ArgumentException("Query timeout value is not a valid integer.");
}
queryTimeout = Convert.ToInt32(queryTimeoutValue) * 1000;
break;

string[] HostKeySpace = Db.DatabaseOperations.TNSCalculated.Split('/');
case var str when str.Contains(sslString):
string sslValue = str.Substring(str.IndexOf(sslString) + sslString.Length);
sslOptions = SetupSslOptions(sslValue);
break;
}
}
string[] HostKeySpace = queryArray[0].ToLower().Replace("http://", "").Replace("https://", "").Split('/');
string[] HostPort = HostKeySpace[0].Split(':');

if (HostPort.Length == 2)
{
if (string.IsNullOrEmpty(Db.Pass) && string.IsNullOrEmpty(Db.User))
{
cluster = Cluster.Builder().AddContactPoint(HostPort[0]).WithPort(Int32.Parse(HostPort[1])).WithQueryTimeout(queryTimeout).Build();
if (sslOptions ==null)
{
cluster = Cluster.Builder().AddContactPoint(HostPort[0]).WithPort(Int32.Parse(HostPort[1])).WithQueryTimeout(queryTimeout).Build();
}
else
{
cluster = Cluster.Builder()
.AddContactPoint(HostPort[0])
.WithPort(Int32.Parse(HostPort[1]))
.WithSSL(sslOptions)
.WithQueryTimeout(queryTimeout)
.Build();
}
}
else
{
cluster = Cluster.Builder().WithCredentials(Db.User.ToString(), Db.Pass.ToString()).AddContactPoint(HostPort[0]).WithPort(Int32.Parse(HostPort[1])).WithQueryTimeout(queryTimeout).Build();
if (sslOptions == null) {
cluster = Cluster.Builder().WithCredentials(Db.User.ToString(), Db.Pass.ToString()).AddContactPoint(HostPort[0]).WithPort(Int32.Parse(HostPort[1])).WithQueryTimeout(queryTimeout).Build();
}
else
{
cluster = Cluster.Builder()
.AddContactPoint(HostPort[0])
.WithPort(Int32.Parse(HostPort[1]))
.WithAuthProvider(new PlainTextAuthProvider(Db.User, Db.Pass))
.WithSSL(sslOptions)
.WithQueryTimeout(queryTimeout)
.Build();
}
}
}
else
Expand All @@ -85,16 +128,16 @@
}
catch (Exception e)
{
Reporter.ToLog(eLogLevel.ERROR, "Failed to connect to Cassandra DB", e);
throw (e);
Reporter.ToLog(eLogLevel.ERROR, "Failed to connect to Cassandra DB. Please check Connection String", e);
throw;
}
}

public override bool MakeSureConnectionIsOpen()
{
try
{
if (session != null)
if (session != null && !session.IsDisposed)
aditydha marked this conversation as resolved.
Show resolved Hide resolved
{
Metadata m = cluster.Metadata;
ICollection<string> Keyspaces = m.GetKeyspaces();
Expand Down Expand Up @@ -184,6 +227,7 @@
{
session.Dispose();
cluster.Dispose();
session = null;
aditydha marked this conversation as resolved.
Show resolved Hide resolved
}

public Type TypeConverter(RowSet RS, string Type1)
Expand Down Expand Up @@ -789,5 +833,20 @@
i++;
}
}

public static SSLOptions SetupSslOptions(string sslParamValue)
{
try
{
var sslProtocol = Enum.Parse<SslProtocols>(sslParamValue);
return new SSLOptions(sslProtocol, false, (_, _, _, _) => true);
}
catch (ArgumentException e)
{
Reporter.ToLog(eLogLevel.ERROR, "SSL value not correct. Please enter SSL value like Default, None, Ssl2, Ssl3, Tls, Tls11, Tls12, Tls13", e);
Reporter.ToLog(eLogLevel.ERROR, "Note - Also try removing ssl= parameter from connection string", e);
throw new ArgumentException("SSL value not correct. Please enter SSL value like Default, None, Ssl2, Ssl3, Tls, Tls11, Tls12, Tls13.");
}
}
aditydha marked this conversation as resolved.
Show resolved Hide resolved
}
}
6 changes: 4 additions & 2 deletions Ginger/GingerCoreNET/Database/NoSqlBase/GingerCouchbase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ private string GetBucketName(string inputSQL)
{
string bucketName = string.Empty;
string[] bucketNameArray;
const string strUpdate = "update ";
const string strFrom = " from ";
if (Action == ActDBValidation.eDBValidationType.RecordCount)
{
bucketName = inputSQL.Replace("`", "");
Expand All @@ -164,11 +166,11 @@ private string GetBucketName(string inputSQL)
{
if (Action == ActDBValidation.eDBValidationType.UpdateDB)
{
bucketName = inputSQL.Substring(inputSQL.ToLower().IndexOf("Update ") + 7);
bucketName = inputSQL.Substring(inputSQL.IndexOf(strUpdate, StringComparison.OrdinalIgnoreCase) + 7);
aditydha marked this conversation as resolved.
Show resolved Hide resolved
}
else
{
bucketName = inputSQL.Substring(inputSQL.ToLower().IndexOf(" from ") + 6);
bucketName = inputSQL.Substring(inputSQL.IndexOf(strFrom, StringComparison.OrdinalIgnoreCase) + 6);
}
bucketNameArray = bucketName.Split('.');
bucketName = bucketNameArray[0].Trim();
Expand Down
Loading