Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix - 39085, 39077 - Virtual Runset Tooltip & Name Conflict Fix #3601

Merged
merged 9 commits into from
Apr 11, 2024
Merged

BugFix - 39085, 39077 - Virtual Runset Tooltip & Name Conflict Fix #3601

merged 9 commits into from
Apr 11, 2024

Conversation

IamRanjeetSingh
Copy link
Contributor

@IamRanjeetSingh IamRanjeetSingh commented Apr 11, 2024 •
edited
Loading

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

@IamRanjeetSingh
Bug: When we load a virtual runset, we show '(Virtual)' suffix in the…
3b23892 
… tooltip of the runset. After saving the runset, the runset is not virtual anymore but the tooltip suffix was still not getting removed.

RC: Tooltip text was not getting updated based on the IsVirtual property of the Runset.
Fix: Update the tooltip text depending on the IsVirtual property of the runset.
@IamRanjeetSingh
Bug: While loading virtual runset, if a runset with same name already…
f5437a0 
… exists then, the new runset was getting created with name suffix '-Copy', '-Copy-Copy' instead of that we expect it to get created as '-Copy', '-Copy2'.

RC: The logic for creating unique runset name was not correct.
Fix: Fixed the unique runset name creation logic.
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 11, 2024 •
edited
Loading

Walkthrough

The updates involve enhancing the management of property changes in RunSetConfig by integrating event handlers and tooltip adjustments in NewRunSetPage.xaml.cs. Additionally, the naming convention for runsets in RunsetFromReportLoader.cs has been refined to incorporate a copy count and identifier for improved clarity and uniqueness.

Changes

File Path Change Summary
.../NewRunSetPage.xaml.cs Enhanced handling of property changes in RunSetConfig, added event handlers, and updated tooltips.
.../RunsetFromReportLoader.cs Renamed SolutionRepositoryContainsRunsetWithName to RunsetExist and improved unique name generation.

🐰✨
In the realm of code, where changes abound,
A rabbit hopped in, with leaps and bound.
Tweaking names and events so spry,
Ensuring tooltips and labels comply.
Oh, how the code now elegantly flows,
Thanks to the rabbit with the coding prose! 🌟
🐰💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Ginger/GingerCoreNET/Reports/RunsetFromReportLoader.cs Outdated Show resolved Hide resolved
Ginger/Ginger/RunSetPageLib/NewRunSetPage.xaml.cs Outdated Show resolved Hide resolved
@IamRanjeetSingh IamRanjeetSingh changed the title BugFix - 39085 - Duplicate Virtual Runset Name Conflict BugFix - 39085, 39077 - Virtual Runset Tooltip & Name Conflict Fix Apr 11, 2024
Maheshkale447
Maheshkale447 previously approved these changes Apr 11, 2024
View reviewed changes
@Maheshkale447 Maheshkale447 merged commit 7e3d0f1 into Releases/Beta Apr 11, 2024
1 check passed
@Maheshkale447 Maheshkale447 deleted the BugFix/39085-DuplicateVirtualRunsetNameConflict branch April 11, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Maheshkale447 Maheshkale447 Maheshkale447 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IamRanjeetSingh @Maheshkale447