Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Valid error message in case of External Id is null or incorrect #3668

Merged

Conversation

AmanPrasad43
Copy link
Contributor

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Copy link
Contributor

coderabbitai bot commented May 7, 2024

Walkthrough

The recent updates enhance the ALM integration and error handling in Ginger's software. A new enum and message were introduced to better manage incorrect external IDs. Additionally, the AzureDevOpsCore module now features more robust logic for connecting to Azure DevOps, parsing IDs, and managing test data, ensuring smoother operations and better error responses.

Changes

File Path Change Summary
.../ReporterLib/UserMsgsPool.cs Added ALMIncorrectExternalID enum and corresponding user message.
.../ALMLib/Azure/AzureDevOpsCore.cs Refactored ALM export logic, improved ID parsing, connection handling, and error management.

🐰✨
A hop, a skip, a code deploy,
New changes we now employ.
Bugs in the grass, no more hassle,
Smooth running, like a castle.
Cheers to code that's neat and spry!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3a3b1c8 and cf3c3b4.
Files selected for processing (2)
  • Ginger/GingerCoreCommon/ReporterLib/UserMsgsPool.cs (2 hunks)
  • Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs (1 hunks)
Files not reviewed due to errors (1)
  • Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs (no review received)
Additional comments not posted (2)
Ginger/GingerCoreCommon/ReporterLib/UserMsgsPool.cs (2)

106-106: The addition of the enum value ALMIncorrectExternalID is correctly implemented.


547-547: The addition of the user message for the key ALMIncorrectExternalID is correctly implemented and follows the established pattern for user messages.

@Maheshkale447 Maheshkale447 merged commit 28b088d into Releases/Official-Release May 7, 2024
8 of 9 checks passed
@Maheshkale447 Maheshkale447 deleted the BugFix/D40192IncorrectMsgAzure branch May 7, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants