-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Valid error message in case of External Id is null or incorrect #3668
Fix - Valid error message in case of External Id is null or incorrect #3668
Conversation
WalkthroughThe recent updates enhance the ALM integration and error handling in Ginger's software. A new enum and message were introduced to better manage incorrect external IDs. Additionally, the AzureDevOpsCore module now features more robust logic for connecting to Azure DevOps, parsing IDs, and managing test data, ensuring smoother operations and better error responses. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- Ginger/GingerCoreCommon/ReporterLib/UserMsgsPool.cs (2 hunks)
- Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs (1 hunks)
Files not reviewed due to errors (1)
- Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs (no review received)
Additional comments not posted (2)
Ginger/GingerCoreCommon/ReporterLib/UserMsgsPool.cs (2)
106-106
: The addition of the enum valueALMIncorrectExternalID
is correctly implemented.
547-547
: The addition of the user message for the keyALMIncorrectExternalID
is correctly implemented and follows the established pattern for user messages.
Thank you for your contribution.
Before submitting this PR, please make sure: