-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Attachments was not getting attached to Bug/Defect on Azure DevOps #3678
Fix - Attachments was not getting attached to Bug/Defect on Azure DevOps #3678
Conversation
WalkthroughThe recent updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs (2 hunks)
Files not reviewed due to errors (1)
- Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs (no review received)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs (1)
Line range hint
182-225
: Consider handling the potential forAggregateException
when using.Result
on asynchronous calls.- Microsoft.TeamFoundation.WorkItemTracking.WebApi.Models.WorkItem newWorkItem = workItemTrackingClient.CreateWorkItemAsync(patchDocument, login.Project, "Bug").Result; + Microsoft.TeamFoundation.WorkItemTracking.WebApi.Models.WorkItem newWorkItem = await workItemTrackingClient.CreateWorkItemAsync(patchDocument, login.Project, "Bug");This change switches to using
await
instead of.Result
, which can help avoid deadlocks and better handle exceptions.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs (5 hunks)
Additional Context Used
GitHub Check Runs (1)
Codacy Static Code Analysis action_required (1)
Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs: [notice] 244-244: Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs#L244
There's no need to call 'ToString()' on a string.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs
Thank you for your contribution.
Before submitting this PR, please make sure: