Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Consumer Pop Up message on missing TA due to new implemented… #3697

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

AmanPrasad43
Copy link
Contributor

… logic for Business Level TA

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Copy link
Contributor

coderabbitai bot commented May 10, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

The recent updates involve streamlining the BusinessFlow.cs in the GingerCoreCommon module. Key modifications include the removal of a conditional message block in the MapTAToBF method and the complete deletion of the MapCAToBF method, which previously handled consumer application-related mappings.

Changes

File Path Change Summary
.../BusinessFlowLib/BusinessFlow.cs Removed conditional message block in MapTAToBF; Deleted MapCAToBF method.

Poem

🐰💻✨
Oh, hop hop hooray, for the cleaner code day,
Where clutter leaves, and clarity stays.
Gone are the blocks, no more redundant talks,
In the land of code, where simplicity rocks!
🌟📜🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between d982ee9 and 0d3cec4.
Files selected for processing (1)
  • Ginger/GingerCoreCommon/Repository/BusinessFlowLib/BusinessFlow.cs (2 hunks)
Additional comments not posted (2)
Ginger/GingerCoreCommon/Repository/BusinessFlowLib/BusinessFlow.cs (2)

Line range hint 2380-2380: The conditional block that appended messages to messageToUser has been successfully removed as per the PR description.


Line range hint 2380-2380: The method MapCAToBF has been successfully removed as per the PR description.

@Maheshkale447
Copy link
Contributor

Please point it to master branch and test it with parser service and with export to BPMN file

Maheshkale447
Maheshkale447 previously approved these changes Jun 6, 2024
@Maheshkale447 Maheshkale447 changed the base branch from Releases/Official-Release to master June 7, 2024 10:30
@Maheshkale447 Maheshkale447 dismissed their stale review June 7, 2024 10:30

The base branch was changed.

@Maheshkale447 Maheshkale447 merged commit 077411c into master Jun 7, 2024
1 check passed
@Maheshkale447 Maheshkale447 deleted the BugFix/ConsumerPopUpMsgObsolete branch June 7, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants