Auth: Add support for emulator #38
Merged
+164
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, test please add emulators to the CI |
fmasa
force-pushed
the
auth-emulator
branch
2 times, most recently
from
0ebbaa4
to
7e21035
Compare
|
@nbransby Added an emulator to tests, though this could use more polish (I will take a look at it bit more). I plan to work on implementing the some of the other |
fmasa
commented
Oct 9, 2024
| "port": 9099 | ||
| }, | ||
| "ui": { | ||
| "enabled": true |
There was a problem hiding this comment.
This is not really necessary for CI, but it's useful when developing.
fmasa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Authentication emulator.
Extracted the URL building to
UrlFactorythat supports emulator URL that is prefixed to the original URL.I can add emulators to CI so this is actually tested against the emulator at least.