updated Firebase SDKs #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suntrix
force-pushed
the
sdk-updates
branch
3 times, most recently
from
a92106b
to
8efeec9
Compare
nbransby
reviewed
Nov 18, 2021
firebase-config/src/jsTest/kotlin/dev/gitlive/firebase/remoteconfig/FirebaseRemoteConfig.kt
Outdated
Show resolved
Hide resolved
|
as you can see from this PR https://github.com/GitLiveApp/firebase-kotlin-sdk/pull/224/files we actually removed that ktx dependency intentionally. my preference would be to remove all the ktx dependencies - it pulls in extra dependencies aka extra bloat for the end user of this library which they don't gain from in anyway and we don't really need to use the ktx extensions internally in the lib |
… version of firebase npm dependency in gradle
|
@nbransby I removed all -ktx dependencies & rebased on top of master |
suntrix
changed the title
nbransby
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.