[Functions] Fix iOS exception message #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbransby
approved these changes
May 16, 2022
|
@walkingbrad thanks for the clear description of the issue! |
walkingbrad
force-pushed
the
functions-ios-error-msg
branch
from
47b4e35
to
6024a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error is returned in a cloud function (e.g.
HttpsError("internal", "This is the error message")), theactualiOS implementation incorrectly propagates the message toFirebaseFunctionsException.Rather than set
message = message, it setsmessage = theNSError.toString()which produces an Objective-C string representation of the error. This prevents us from being able to parse that field reliably, since it is in an unstructured format and is inconsistent between Android and iOS.This change brings iOS in parity with Android, where the exception's
messagematches that of the error returned by Firebase.e.g.
message = "This is the error message"