Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run android emulator on ubuntu build agent #524

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Run android emulator on ubuntu build agent #524

merged 1 commit into from
Jun 19, 2024

Conversation

siarhei-luskanau
Copy link
Contributor

No description provided.

@nbransby
Copy link
Member

@siarhei-luskanau were you hoping this might fix the fakey android tests?

@Reedyuk
Copy link
Collaborator

Reedyuk commented Jun 14, 2024

Seems to be failing, could you fix it and get it passing. Happy to merge once it passes

@siarhei-luskanau
Copy link
Contributor Author

@siarhei-luskanau were you hoping this might fix the fakey android tests?

I will try to fix the android tests. Additional I would like to add the gradle-managed-devices to project and use it instead of reactivecircus/android-emulator-runner GitHub action task

@Reedyuk
Copy link
Collaborator

Reedyuk commented Jun 14, 2024

ok that makes sense. Use this pr to do those changes and get the tests passing and i will review and get it merged in

@nbransby
Copy link
Member

Execution failed for task ':firebase-app:gradleManagedDeviceSetup'.

A failure occurred while executing com.android.build.gradle.internal.tasks.ManagedDeviceInstrumentationTestSetupTask$ManagedDeviceSetupRunnable
java.util.concurrent.ExecutionException: com.android.builder.sdk.LicenceNotAcceptedException: Failed to install the following Android SDK packages as some licences have not been accepted.
system-images;android-33;google_atd;x86_64 Google APIs ATD Intel x86_64 Atom System Image
To build this project, accept the SDK license agreements and install the missing components using the Android Studio SDK Manager.
All licenses can be accepted using the sdkmanager command line tool:
sdkmanager.bat --licenses
Or, to transfer the license agreements from one workstation to another, see https://developer.android.com/studio/intro/update.html#download-with-gradle

 Using Android SDK: /usr/local/lib/android/sdk

@siarhei-luskanau siarhei-luskanau marked this pull request as draft June 17, 2024 00:07
@siarhei-luskanau
Copy link
Contributor Author

@Reedyuk @nbransby I managed to split the android tests by modules. Now GitHub Actions launch the build agent for each Gradle module with android tests.
I still in progress with replacing the reactivecircus/android-emulator-runner with the gradle-managed-devices

@Reedyuk
Copy link
Collaborator

Reedyuk commented Jun 19, 2024

@Reedyuk @nbransby I managed to split the android tests by modules. Now GitHub Actions launch the build agent for each Gradle module with android tests. I still in progress with replacing the reactivecircus/android-emulator-runner with the gradle-managed-devices

Really nice work, thanks for the contribution.
What is the impact on merging this in now? you can add a new pr for the other change?

@Reedyuk
Copy link
Collaborator

Reedyuk commented Jun 19, 2024

Ah crashlytics is failing

@siarhei-luskanau
Copy link
Contributor Author

Ah crashlytics is failing

Right! Crashlytics is failing. Benefit on that PR is splitting tests by module. So other modules is tested successfully.

@siarhei-luskanau
Copy link
Contributor Author

What is the impact on merging this in now? you can add a new pr for the other change?

This PR contains unused and uncompleted code related he gradle-managed-devices.
I will continue this in other PR

@siarhei-luskanau siarhei-luskanau marked this pull request as ready for review June 19, 2024 08:07
@Reedyuk
Copy link
Collaborator

Reedyuk commented Jun 19, 2024

Ah crashlytics is failing

Right! Crashlytics is failing. Benefit on that PR is splitting tests by module. So other modules is tested successfully.

Get a green tick on all and happy to merge this in.

@siarhei-luskanau
Copy link
Contributor Author

@Reedyuk I have applied the gradle-managed-devices with api 33 instead of 34. Right now I see emulator failing with api 34

…is used instead of reactivecircus/android-emulator-runner GitHub action task
@siarhei-luskanau
Copy link
Contributor Author

@Reedyuk I have added the devRunEmulatorTests Gradle task for developers to launch Android tests locally

@Reedyuk Reedyuk merged commit 90fba35 into GitLiveApp:master Jun 19, 2024
13 checks passed
@Reedyuk
Copy link
Collaborator

Reedyuk commented Jun 19, 2024

Thank you for your hard work @siarhei-luskanau

@siarhei-luskanau siarhei-luskanau deleted the ci-android-emulator branch June 19, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants