-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OOM due to update avalanches #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the PR. Will release 1.0.7 in a few minutes. 👍 |
I knew I wanted to do something more before submitting the PR o_O |
No problem, tests are a pain in the *** to update, I don't blame you 😄 |
GitSquared
pushed a commit
that referenced
this pull request
May 13, 2020
GitSquared
pushed a commit
that referenced
this pull request
Jan 23, 2022
github-actions bot
pushed a commit
to langyan1022/node-geolite2-redist
that referenced
this pull request
Oct 26, 2023
github-actions bot
pushed a commit
to langyan1022/node-geolite2-redist
that referenced
this pull request
Oct 26, 2023
github-actions bot
pushed a commit
to langyan1022/node-geolite2-redist
that referenced
this pull request
Oct 26, 2023
github-actions bot
pushed a commit
to langyan1022/node-geolite2-redist
that referenced
this pull request
Oct 28, 2023
github-actions bot
pushed a commit
to langyan1022/node-geolite2-redist
that referenced
this pull request
Oct 28, 2023
github-actions bot
pushed a commit
to langyan1022/node-geolite2-redist
that referenced
this pull request
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Date.now() - proxyObject.lastUpdateCheck > updateTimer
on every property access.lastUpdateCheck
starts out as 0 and is only updated on receiving achecking
event.checking
event is delayed by at least 200 ms in.checkUpdates()
(running after_wait(200)
)lastUpdateCheck
is still 0 during those first 200ms.Result
Process went up to consume 20GB of physical memory, swapping out most the physical memory of most other processes and eventually getting OOM killed by the kernel. Oops.
Fix
Remove the
lastUpdateCheck/checkUpdates()
calls from the proxy object completely. TheUpdateSubscriber
will perform these anyway already. No need to have this triggered on property access, kinda redundant.Also, move out the
proxyObject.subscriber
setup from the proxyget
into the mainwrapReader
body. No need to permanently check the creation when it's created exactly once anyway.Also,
triggerUpdate()
is useless; stubbed.