Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE]: GRM publish uses incorrect labels #1183

Closed
2 tasks done
mkevenaar opened this issue Jul 22, 2024 · 4 comments · Fixed by #1186
Closed
2 tasks done

[ISSUE]: GRM publish uses incorrect labels #1183

mkevenaar opened this issue Jul 22, 2024 · 4 comments · Fixed by #1186

Comments

@mkevenaar
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have searched issues to ensure it has not already been reported

GitVersion package

GitHub Actions

What are you seeing?

According to the manifest, milestone is required. However, GRM uses tagName. This is also required to be able to get the module to work.

PS > grm help publish
GitReleaseManager 0.18.0+e46787339c6740cc14a8b9c83181b7cf70900865
Copyright (C) 2024 GitReleaseManager

  -t, --tagName            Required. The name of the release (Typically this is the generated SemVer Version Number).

  --token                  Required. The Access Token to access Version Control System with.

  -o, --owner              Required. The owner of the repository.

  -r, --repository         Required. The name of the repository.

  --provider               (Default: GitHub) Version Control System provider

  --debug                  Enable debugging console output

  -l, --logFilePath        Path to where log file should be created. Defaults to logging to console.

  --no-logo                Disables the generation of the GRM commandline logo.

  -d, --targetDirectory    The directory on which GitReleaseManager should be executed. Defaults to current directory.

  --verbose                Enable verbose console output

  --ci                     Configure GitReleaseManager to be compatible with CI systems

  --help                   Display this help screen.

What is expected?

Action to be using tagName

Steps to Reproduce

See https://github.com/mkevenaar/CharlieSpring/blob/develop/.github/workflows/release.yaml

Output log or link to your CI build (if appropriate).

No response

@mkevenaar
Copy link
Author

@mkevenaar
Copy link
Author

Duplicate of #1137

Only change that is incorrect would be the example

@arturcic
Copy link
Member

@mkevenaar thanks for finding it, will be fixed in the next release

arturcic added a commit that referenced this issue Jul 22, 2024
#1183 - updated examples to use the correct GRM arguments
@arturcic
Copy link
Member

@mkevenaar v2.0.1 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants