gix feature toggles
#1010
Merged
gix feature toggles
#1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndex This doesn't happen here though, so nothing special we could trigger.
3 tasks
Byron
force-pushed
the
reset
branch
5 times, most recently
from
273c068 to
377f91f
Compare
That way, it's possible to not compile a bunch of code in `gix` if the writing of packs isn't required.
This should make optimizing compile time and performance easier, while assuring these options aren't pre-determined by library providers.
This also removes all diff capabilities.
That way users can more precisely decide what they want to use. Note that spec-parsing is so foundational that it's always included. Those who don't need it nor need describe don't need the crate in the fist place.
`revparse-regex` is only used when parsing revspecs that use a special syntax. This feature is also enabled by default.
This makes it easier to use.
Byron
force-pushed
the
reset
branch
5 times, most recently
from
af00322 to
8c56076
Compare
Byron
force-pushed
the
reset
branch
2 times, most recently
from
f973319 to
e49da62
Compare
…feature toggle. They are also available when using https transports.
Even though there is a chance that overall, it will compile multiple different versions of the same thing so it's not actually faster. But let's not think too much about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1008 .
Implement a proper worktree reset, eventually leading to a high-level reset similar to how git supports it.
Facilitate compile time reduction
gix-packdata-io off using feature togglesgixfeature toggles: remote-connection, blob-diff, revision, attributes, mailmap, regexgix-promptandgix-credentialsdepend on one of the transport featuresgix-indexand others - some might be easily put behind feature toggles../../../. Further, assure that we don't write such refs when receiving them from the server.Tasks
checkout()method as technically that's areset --hardwith optional overwrite check. Could it be rolled into one, with pathspec support added?Postponed
What follows is important for resets, but won't be needed for
cargoworktree resets.Research
mergeandkeep? How to controlrefresh?git resetandgit checkoutin terms ofHEADmodifications. With the former changingHEADs referent, and the latter changingHEADitself.