Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job test-pass for stable job name #1551

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

NobodyXu
Copy link
Contributor

Which can be used in github branch protection

Which can be used in github branch protection
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I think I can use this and the main jobs of the other CI configurations to assure truly everything needs to pass.
And I should be sure to maintain it or there is a risk it auto-merges even though CI is still running.
But I guess it's all worth it to get auto-merge :).

@NobodyXu
Copy link
Contributor Author

Yes it's more convenient than specifying each job manually in github branch protection and a bit easy to update, you just need to update the test-pass to include the newly added jobs

From my experience it's easier

@Byron Byron merged commit e35206b into GitoxideLabs:main Aug 25, 2024
19 checks passed
@Byron
Copy link
Member

Byron commented Aug 25, 2024

Screenshot 2024-08-25 at 09 51 08

All setup now, let's see how it works. ("Allow Auto-Merge" is also enabled in the general settings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants