Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hasconfig:remote.*.url #1656

Merged
merged 4 commits into from
Nov 7, 2024
Merged

hasconfig:remote.*.url #1656

merged 4 commits into from
Nov 7, 2024

Conversation

Byron
Copy link
Member

@Byron Byron commented Nov 6, 2024

Add support for hasconfig:remote.*.url: to gix-config and assure that gix repositories also resolve these kinds of includes correctly.

Motivated by gitbutlerapp/gitbutler#5420

Tasks

  • tests and implementation in gix-config
  • wire it up in gix with basic tests

Research

  • Only this specific keyword is supported.
  • have to prevent direct or indirect inclusion of more remote.*.url keys (sections are fine)
    • implementing this logic is going to be interesting, but should be possible.
  • The glob-match is trivial.

@Byron Byron force-pushed the hasconfig branch 2 times, most recently from 4faf669 to 7826ba4 Compare November 6, 2024 16:31
@Byron Byron marked this pull request as ready for review November 7, 2024 06:43
@Byron Byron enabled auto-merge November 7, 2024 06:44
@Byron Byron merged commit c5955fc into main Nov 7, 2024
16 checks passed
@Byron Byron deleted the hasconfig branch November 7, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant