Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consecutive negotiation #855

Merged
merged 12 commits into from
May 23, 2023
Merged

consecutive negotiation #855

merged 12 commits into from
May 23, 2023

Commits on May 19, 2023

  1. Add new crate for implementing and testing git negotiation logic.

    @Byron
    Byron committed May 19, 2023
    Configuration menu
    Copy the full SHA
    372ba09 View commit details
    Browse the repository at this point in the history

  2. Release gix-commitgraph v0.15.0, gix-revision v0.14.0, gix-negotiate … 

    …v0.1.0, safety bump 7 crates

SAFETY BUMP: gix-revision v0.14.0, gix-negotiate v0.1.0, gix v0.45.0, gix-refspec v0.11.0, gitoxide-core v0.28.0, cargo-smart-release v0.20.0, gitoxide v0.26.0
    @Byron
    Byron committed May 19, 2023
    Configuration menu
    Copy the full SHA
    92832ca View commit details
    Browse the repository at this point in the history

  3. feat: introduce the noop negotiator to establish a basic trait for … 

    …negotiators.
    @Byron
    Byron committed May 19, 2023
    Configuration menu
    Copy the full SHA
    1f6e6d8 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. feat: add at() function on module level. 

    That way it's more similar to `gix_odb::at()` as there is effectively only one
important type.
    @Byron
    Byron committed May 20, 2023
    Configuration menu
    Copy the full SHA
    50b45dc View commit details
    Browse the repository at this point in the history

  2. A baseline test for the noop negotiator

    @Byron
    Byron committed May 20, 2023
    Configuration menu
    Copy the full SHA
    5cd7748 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. feat: various improvements to the API 

    * make `CommitterTimestamp` available as type, making the code using it more descriptive.
* add `new()` to `PriorityQueue`
* add `Graph::try_lookup_and_insert_default()`
* add `Debug` impl for `Graph`
    @Byron
    Byron committed May 23, 2023
    Configuration menu
    Copy the full SHA
    9ab2051 View commit details
    Browse the repository at this point in the history

  2. feat: implement consecutive algorithm. 

    This is the default negotiation algorithm.
    @Byron
    Byron committed May 23, 2023
    Configuration menu
    Copy the full SHA
    01aba9e View commit details
    Browse the repository at this point in the history

  3. feat: implement skipping negotiation algorithm

    @Byron
    Byron committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4aad40d View commit details
    Browse the repository at this point in the history

  4. Attempt to figure out what 'consecutive' needs to pass the tests

    @Byron
    Byron committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1809a99 View commit details
    Browse the repository at this point in the history

  5. figure out what's wrong with 'skipping' and fix it

    @Byron
    Byron committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1b19ab1 View commit details
    Browse the repository at this point in the history

  6. Add a test to also validate interaction with known_common/remote refs

    @Byron
    Byron committed May 23, 2023
    Configuration menu
    Copy the full SHA
    5bdd071 View commit details
    Browse the repository at this point in the history

  7. FAIL: try to change test-suite from --negotiate-only to the more real… 

    …istic fetch with --dry-run.

This means we will have to reproduce what git does naturally, to fill in common refs
and also provide tips.

Unfortunately this doesn't work as it's apparently not really dry-running, but modifying
the repository underneath. This means it's not idempotent when running it multiple times.
    @Byron
    Byron committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1571528 View commit details
    Browse the repository at this point in the history